Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix line number for python 3.12 #666

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

penguin-wwy
Copy link

The linetable for 3.12 and 3.11 have the same structure, refactored to a common macro.

Current py-spy dump output on the tests/scripts/longsleep.py test case:

Process 1721748: python tests/scripts/longsleep.py
Python v3.12.1 (/data/home/self/.pyenv/versions/3.12.1/bin/python3.12)

Thread 1721748 (idle)
    longsleep (longsleep.py:5)
    <module> (longsleep.py:9)
    <interpreter trampoline> (<shim>:1)

Copy link
Owner

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this! changes look good to me

@benfred benfred merged commit 983de8d into benfred:python_3_12 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants