Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __init__.py to fix time check for post game thread #6

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

jspayne
Copy link
Collaborator

@jspayne jspayne commented Jun 23, 2023

My first fix for this didn't account for timezone, and flipped the compare.

Fixes #5 , though review still needs to be completed

Copy link
Owner

@benja810 benja810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on that >= vs <=. We'll want to merge that fix into the reddit game bot as well. Can you add that fix into this PR before merging?

@jspayne jspayne linked an issue Jun 23, 2023 that may be closed by this pull request
@jspayne
Copy link
Collaborator Author

jspayne commented Jun 23, 2023

I looked the Reddit version over, and it appears to be correct. I do Now - Post >= 1hr, it does Post <= now - 1hr.

@jspayne jspayne merged commit 4973a2d into benja810:lemmy-game-threads Jun 23, 2023
jspayne added a commit that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review code for unix time issues
2 participants