support dictproxy views Fixes #295

[graingert]

No description provided.

[graingert]

@benjaminp I think this fixes the issues with my previous attempt

[graingert]

@benjaminp any thoughts on this?

[graingert]

#295

[graingert]

@benjaminp any thoughts on this?

[benjaminp]

Thank you for the PR. As I said in #296 (comment), I don't want to complicate view* for this, especially since there's no way to view dict proxy's on Python 2.

[graingert]

Thank you for the PR. As I said in #296 (comment), I don't want to complicate view* for this, especially since there's no way to view dict proxy's on Python 2.

But it does work for dictproxy, you just use the collections.*View

[benjaminp]

Sorry, I meant a method on the type.

[graingert]

I'd like you to reconsider, because it makes it much easier to use six.viewitems everywhere it would also be supported in Py3 (eg class Foo(object): ...; six.viewitems(vars(Foo)) and much easier to produce safe automated transforms when upgrading a py2 codebase to py3

[benjaminp]

I'd like you to reconsider,

I've already considered it twice.

because it makes it much easier to use six.viewitems everywhere it would also be supported in Py3 (eg class Foo(object): ...; six.viewitems(vars(Foo)) and much easier to produce safe automated transforms when upgrading a py2 codebase to py3

What automated transform? If the Python 2 code is doing something.viewitems(), then it already doesn't work it dict proxies. If it's doing something.iteritems(), six.iteritems(something) will work fine.