Tolerate recoverable parse errors.

@jdalton Looks like acorn@5.0.0 got a bit more strict about duplicate variable declarations and import specifiers.
benjamn · Mar 28, 2017 · 19add56 · 19add56 · jdalton · Mar 28, 2017
1 parent aefa703
commit 19add56
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/lib/parsers/acorn.js b/lib/parsers/acorn.js
@@ -10,8 +10,16 @@ exports.options = {
 
 function acornParse(code) {
   var parser = new acorn.Parser(exports.options, code);
+
+  // It's not Reify's job to enforce strictness.
   parser.strict = false;
+
+  // Tolerate recoverable parse errors.
+  parser.raiseRecoverable = noopRaiseRecoverable;
+
   return parser.parse();
 }
 
+function noopRaiseRecoverable() {}
+
 exports.parse = acornParse;
diff --git a/lib/parsers/top-level.js b/lib/parsers/top-level.js
@@ -24,9 +24,19 @@ function quickParseBlock() {
 
 function topLevelParse(code) {
   var parser = new acorn.Parser(exports.options, code);
+
+  // Override the Parser's parseBlock method.
   parser.parseBlock = quickParseBlock;
+
+  // It's not Reify's job to enforce strictness.
   parser.strict = false;
+
+  // Tolerate recoverable parse errors.
+  parser.raiseRecoverable = noopRaiseRecoverable;
+
   return parser.parse();
 }
 
+function noopRaiseRecoverable() {}
+
 exports.parse = topLevelParse;
	it("should support switch-case nested imports", function () {
	assert.strictEqual(typeof x, "undefined");

	for (var i = 0; i < 2; ++i) {
	switch (i) {
	case 0:
	import { a as x } from "./abc";
	break;
	case 1:
	import { b as x } from "./abc";
	break;
	}

	assert.strictEqual(x, i ? "b": "a");
	}

	assert.strictEqual(x, "b");
	});