-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code review notes #90
Comments
The rules for namespace properties are here. The property descriptors should be:
Which means you can create the namespace object as an |
|
I thought that to-do item was more to check if the namespace variable itself could be changed to a value different from the original object, which is what the |
That's what the spec says. I've pinged Brian Terlson to see if it's a spec bug.
Ah ya. Imported identifiers are all |
I looked up taking on
It looks like most all keys are the slow kind because they use file paths. This was a nice to have but not a biggie so |
I wanted to capture the notes I took during our code review.
Moved
Completed
module.exports
,module.import
, andmodule.importSync
.Object.create(null)
import
/export
add'use strict'
__esModule
property non-enumerable- Make the uniqueKey a fast property by changing the:
to a__
or something similarShouldaddGetters
throw? Yes.forEachSetter
(use UNDEFINED lookup)The text was updated successfully, but these errors were encountered: