Fix performance problem from throwing/catching lots of exceptions #242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runGetter
is an inner-loop function that gets called every time anything is imported, and it showed up as a hotspot (~150ms) in my browser Javascript profiler results. Turns out,getter
is sometimes null, which means that the smalltry
/catch
block here generates and consumes a null-reference exception. This is slow, much slower than handling the null case directly. Doing this reduces the time spent in this function to a much more reasonable ~30ms.