Use `Object.create(null)` in a few more places. #78

jdalton · 2017-03-18T09:47:23Z

I noticed while trying to load lodash-es that an error occured here because I had an identifier named toString and the map as a vanilla object and so had a toString method and not the array it was expecting:

var locals = map[__ported] || [];

jdalton · 2017-03-18T09:48:11Z

This should totally have a unit test but I'm not super well versed yet with the setup so it may be easier for you to add in a subsequent commit.

Use Object.create(null) in a few more places.

26e4b99

benjamn merged commit b83a8e7 into benjamn:master Mar 18, 2017

benjamn pushed a commit that referenced this pull request Mar 18, 2017

Use Object.create(null) in a few more places. (#78)

a4b110d

jdalton deleted the map branch March 18, 2017 17:54

jdalton mentioned this pull request Apr 3, 2017

Add unit tests. #109

Open

7 tasks

jdalton added the enhancement label Apr 7, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `Object.create(null)` in a few more places. #78

Use `Object.create(null)` in a few more places. #78

jdalton commented Mar 18, 2017

jdalton commented Mar 18, 2017

Use Object.create(null) in a few more places. #78

Use Object.create(null) in a few more places. #78

Conversation

jdalton commented Mar 18, 2017

jdalton commented Mar 18, 2017

Use `Object.create(null)` in a few more places. #78

Use `Object.create(null)` in a few more places. #78