Should integrate Hls.Events.FRAG_PARSING_METADATA for video.js exposure of hls id3 frames

[ram651]

FRAG_PARSING_METADATA was recently introduced and merged into hls.js and exposes the current fragment's ID3 frame to the API upon firing.

[whatvn]

what exactly you want to do?
Did you mean we should catch the event and fire videojs event on FRAG_PARSING_METADATA and its data so we can use that data later? if so I think i can do something with it.

[ram651]

that is the idea
On Jan 11, 2016 8:04 PM, "Hung Nguyen" notifications@github.com wrote:

what exactly you want to do?
Did you mean we should catch the event and fire videojs event on
FRAG_PARSING_METADATA and its data so we can use that data later? if so I
think i can do something with it.

—
Reply to this email directly or view it on GitHub
#7 (comment)
.

[whatvn]

@ram651 can you try my pull request #8 ?

[ram651]

The data getting thrown is completely different now than when catching the same info from just hls.js. I'm not sure why this is, but when catching the data from hls.js the data is formatted as such:

pts, dts, and data(which is a smaller scale Uint8Array)

but now with this video.js plugin, the data getting thrown is:

endDTS, endPTS, startDTS, endPTS, and two Uint8Arrays of much larger size

hls.js

videojs-hlsjs.js

[whatvn]

hmm, which data of hlsjs you checked?
I double checked here and event data is fired inside hlsjs is exactly what you showed in 2nd picture.

[ram651]

Sample code that is producing the first image of data from hls.js:

hls.on(Hls.Events.FRAG_PARSING_METADATA, function(event, data){
     console.log(data);
});

You can reference Issue 159 from hls.js's github to see where another is referencing the same metadata for the stream's ID3 tags

[whatvn]

the pull request I made is just pass whatever data hls produced to trigger event for videojs.
I cannot do anything better.