Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for sunset/sunrise #60

Merged
merged 7 commits into from
Jan 17, 2021
Merged

Added support for sunset/sunrise #60

merged 7 commits into from
Jan 17, 2021

Conversation

paviro
Copy link
Contributor

@paviro paviro commented Dec 27, 2020

This tries to solve #40. I don't 100% understand your code (totally my issue :D) so please correct me if I missed anything.

I am not 100% sure if there are any changes needed to for example:

if await self.now_is_between(str(dt_start), str(next_dt_start)):
                await self.switch_daytime(dict(daytime=daytime, initial=True))
                self.active_daytime = daytime.get("daytime")

Because of the change from time.fromisoformat to self.parse_time. In my tests I got the same data back and I haven't run into any issues yet.

@benleb benleb self-assigned this Dec 28, 2020
@benleb benleb added the enhancement New feature or request label Dec 28, 2020
@paviro
Copy link
Contributor Author

paviro commented Dec 28, 2020

Not sure why linting failed now 🙃

@benleb benleb merged commit db4cd2c into benleb:master Jan 17, 2021
@benleb
Copy link
Owner

benleb commented Jan 17, 2021

Thanks!

@benleb benleb mentioned this pull request Jan 17, 2021
@tjedrak
Copy link

tjedrak commented Jan 17, 2021

@benleb can you release it? I can't see the updated version in HACS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants