Skip to content

Commit

Permalink
go: downgrade from Go 1.23 to 1.22 to fix an Android bug
Browse files Browse the repository at this point in the history
Android app compiled with 1.23.2 or 1.23.3 crashes on old Android
verisons (verified crash on Android 9 and Android 10).

Until Go is fixed, we downgrade to the prevoius version we used that
works.
  • Loading branch information
benma committed Nov 20, 2024
1 parent 95c0c41 commit fe1117f
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ env:
# https://docs.github.com/en/packages/guides/pushing-and-pulling-docker-images
#
# Keep this in sync with default in scripts/github-ci.sh.
CI_IMAGE: ghcr.io/bitboxswiss/bitbox-wallet-app-ci:25
CI_IMAGE: ghcr.io/bitboxswiss/bitbox-wallet-app-ci:26
GITHUB_BUILD_DIR: ${{github.workspace}}

jobs:
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/BitBoxSwiss/bitbox-wallet-app

go 1.23
go 1.22

require (
github.com/BitBoxSwiss/bitbox02-api-go v0.0.0-20240925080402-a2115fee878e
Expand Down
2 changes: 1 addition & 1 deletion scripts/docker_install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ npm install -g npm@10
npm install -g locize-cli

mkdir -p /opt/go_dist
curl https://dl.google.com/go/go1.23.2.linux-amd64.tar.gz | tar -xz -C /opt/go_dist
curl https://dl.google.com/go/go1.22.4.linux-amd64.tar.gz | tar -xz -C /opt/go_dist

# fuse is needed to run the linuxdeployqt appimage.
apt-get install -y --no-install-recommends fuse
Expand Down
2 changes: 1 addition & 1 deletion scripts/github-ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ if [ "$OS_NAME" == "linux" ]; then
# Which docker image to use to run the CI. Defaults to Docker Hub.
# Overwrite with CI_IMAGE=docker/image/path environment variable.
# Keep this in sync with .github/workflows/ci.yml.
: "${CI_IMAGE:=shiftcrypto/bitbox-wallet-app:25}"
: "${CI_IMAGE:=shiftcrypto/bitbox-wallet-app:26}"
# Time image pull to compare in the future.
time docker pull "$CI_IMAGE"

Expand Down

0 comments on commit fe1117f

Please sign in to comment.