Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Readme Rmd to qmd #157

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Changing Readme Rmd to qmd #157

merged 3 commits into from
Jun 6, 2024

Conversation

jbelmiro
Copy link
Contributor

@jbelmiro jbelmiro commented Jun 6, 2024

Hello Ben. I changed the rmd to qmd for the read-me file. I just ran the packages and followed all the steps to create a compendium, and there was no issue. The qmd read-me file was created and rendered just fine. But again, I'm still learning so let me know if this worked.

@benmarwick
Copy link
Owner

Thanks so much for this, fantastic to see!

Before I merge it, would you mind to have a look at your copy of test-005-use_readme_rmd.R and replace Rmd with qmd throughout that file?

Please also update the DESCRIPTION to add your name to the contributor list.

When you commit those changes on your local version, and then push to your fork, this pull request will automatically update.

Thanks again!

Ben

@benmarwick benmarwick merged commit 68d0831 into benmarwick:master Jun 6, 2024
1 of 5 checks passed
@benmarwick
Copy link
Owner

Excellent work, thank you so much. This is a really nice contribution that helps to keep rrtools up with the state of the art in literate programming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants