fix unambiguous regex #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfmengels
requested changes
Nov 5, 2016
There was a problem hiding this comment.
Well this is good news. I'm happy it was just silly mistakes rather than very hard performance problems :D
I just noticed a typo, but feel free to dismiss the request for changes when you've fixed that.
To be on the safe side, and since it doesn't cost much, I think eslint-module-utils should be bumped by a major version. In both cases, there may not be a lot of things affected, but you never know, and this is the right thing to do IMO when you know it's a breaking change.
| @@ -344,4 +345,23 @@ describe('ExportMap', function () { | |||
|
|
|||
| }) | |||
|
|
|||
| // todo: move to utils | |||
| describe('unambigous regex', function () { | |||
|
@jfmengels I agree about bumping |
jfmengels
approved these changes
Nov 7, 2016
|
Just tested v2.2.0 out on my codebase, and performance now appears to be comparable to v1.16.0. Thanks so much! (Details in #649) |
This was referenced Apr 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key notes:
&&instead of||for the auto-ignore (fail) so it wasn't even used unless the file is ignored anyway, and then it would ignore the ignore if the regex passedmultilinemode, so it would fail on files unlessimport/exportis the first line (double fail)I also had to comment out a parser error test for CoffeeScript that should never have passed in v2 if I had implemented this correctly to begin with.
To publish this, need to bump+publish
eslint-module-utils, then bump the dep in the plugin and publish it too.I'm thinking this should be semver-minor since it's a large enough fix that it's nearly a feature.
Technically a breaking change to
eslint-module-utils, but that's not a big deal.fixes #615
fixes #634
fixes #649