-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 is SLOW #615
Comments
Same here. I had to disable it because of the performance regression. Is there a way we can help? |
Interesting. Could be that the fail-fast regex for unambiguous module detection is getting a lot of false positives. You could try using the import/ignore setting to ignore node_modules; if it helps considerably, I suspect this is the issue. |
@benmosher I added the following to my
it doesn't help |
@indeyets Hmm, could you try to deactivate rules to find out which one is causing the lag? @benmosher seems to think it's the |
My configuration is this one if that can be helpful:
|
Is that extra colon inside the quotes actually in your config? |
Btw @jfmengels + all: I'm not saying it's the unambiguous rule, I'm saying it's the new auto-ignore that parses dependencies to see if they have exports or imports, and ignores them if they don't. Historically, most of the time is dependency parse time. There is a regex that is a lot faster than a full JS parse that should prevent parsing most non-ES-module deps. I'm thinking some part of that must not be working for @indeyets, thus my suspicion that explicitly ignoring node_modules would help a lot. Probably just need to add some timing and debug logging and do some real forensics. 😅 I didn't notice a bug slowdown on my work projects with tons of CJS deps, so maybe those that have commented here have something going on that I don't yet understand. But if it was fast before, it should be able to be made fast again. 😄 |
@benmosher you're right. the colon was an issue. I fixed the setting and scan-time is reasonable again 👍 |
Cool! |
@indeyets sweet! it does mean you're losing any linting of node_modules that have at some point I'd like to profile the linked project without ignoring |
reopening because I want to fix in v3 |
Upgrading eslint-plugin-import led to significant change in speed of eslint scan on several codebases I support.
For example, https://github.com/FreeFeed/freefeed-server:
Is this expected?
The text was updated successfully, but these errors were encountered: