Update README to link to coinbase-pro-node deprecation comment #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a pedantic change, but when I first found this package I had to do some hunting to check if the official
coinbase-pro-nodepackage had been deprecated, or onlycoinbase-node.The README currently links to a comment on a PR for
coinbase-node- the package for the "normal" Coinbase API. But this package is for Coinbase Pro (formerly Gdax) so that's not relevant. I saw on the coinbase-pro-node repo all those PRs are also closed for the same reason: https://github.com/coinbase/coinbase-pro-node/issues?q=is%3Aissue+is%3AclosedSo I've just updated the README here to reference the coinbase-pro-node package instead of coinbase-node.