add back config api #165
Merged
add back config api #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 17f3f74.
fenollp
reviewed
Jan 5, 2017
| ?assertEqual({ok, <<"2">>}, couchbeam:get_config(Server, <<"couchbeam">>, <<"test">>)), | ||
| ?assertEqual({ok, <<"2">>}, couchbeam:delete_config(Server, <<"couchbeam">>, <<"test">>, false)), | ||
| ?assertEqual({error, not_found}, couchbeam:get_config(Server, <<"couchbeam">>, <<"test">>)), | ||
| ok. |
There was a problem hiding this comment.
Note: to properly count the tests:
- suffix the function with
_test_(config_test_() ->) - wrap these asserts in a list & prefix them with
_([?_assertEqual(<<"5984">>, Port), ...]) - remove that last
ok
There was a problem hiding this comment.
@fenollp this is a reverse commit, not updating anything here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need this for older version like bigcouch