Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async workers broken on Python 3.7 due to backwards-incompatible change #1823

Closed
Bogdanp opened this issue Jun 29, 2018 · 3 comments
Closed

Async workers broken on Python 3.7 due to backwards-incompatible change #1823

Bogdanp opened this issue Jun 29, 2018 · 3 comments

Comments

@Bogdanp
Copy link

Bogdanp commented Jun 29, 2018

Per the release notes of Python 3.7, "async" and "await" are now reserved keywords. This means that async workers like gevent no longer work because they try to import the gevent.workers.async module, which is now a SyntaxError:

  File "/Users/bogdan/.virtualenvs/molten/lib/python3.7/site-packages/gunicorn/workers/ggevent.py", line 30
    from gunicorn.workers.async import AsyncWorker
                              ^
SyntaxError: invalid syntax

The obvious fix would be to rename the async module to something else, but I believe that would constitute a breaking change so I figured I'd open an issue before attempting to contribute.
@jamadden
Copy link
Collaborator

This has already been addressed. See #1822

@Bogdanp
Copy link
Author

Bogdanp commented Jun 29, 2018

Ahh, can't believe I missed that. Thanks, @jamadden!

@Bogdanp Bogdanp closed this as completed Jun 29, 2018
@tilgovi
Copy link
Collaborator

tilgovi commented Jul 4, 2018

Gunicorn 19.9.0 has been released!

0x4Dark added a commit to DATAGerry/DATAGerry that referenced this issue Dec 27, 2018
@0x4Dark
[FIX] gunicorn update error with gevent
736c894 
see benoitc/gunicorn#1823
@nilsnolde nilsnolde mentioned this issue Feb 21, 2020
Open
19 tasks
@windson windson mentioned this issue Jan 6, 2021
Closed
johnbradley added a commit to Duke-GCB/D4S2 that referenced this issue Jun 28, 2022
@johnbradley
Upgrade gunicorn for async keyword bug
7453c15 
Fixes error described here: benoitc/gunicorn#1823
johnbradley added a commit to Duke-GCB/D4S2 that referenced this issue Aug 29, 2022
@johnbradley
Setup Azure delivery to use data factory
d6bc6f1 
Use compatible psycopg2 package.
Adds transfer_uuid for securing azure deliveries.

Upgrade to python 3.8
  Python 3.9 had an error building greenlet

Upgrade gunicorn for async keyword bug
  Fixes error described here: benoitc/gunicorn#1823

Use Storage-as-a-Service to check recipient container url

Checks the container url entered in the acceptance web form is
owned by the recipient(current user). This is done using the
SAAS `/api/FileSystems/{account}/{container}` API endpoint.
Currently this endpoint fails with a 500 for storage accounts
it cannot find.
See microsoft/storage-as-a-service#111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tilgovi @Bogdanp @jamadden