Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate init_process method in EventletWorker #657

Closed
olt opened this issue Dec 9, 2013 · 3 comments
Closed

Duplicate init_process method in EventletWorker #657

olt opened this issue Dec 9, 2013 · 3 comments

Comments

@olt
Copy link
Contributor

olt commented Dec 9, 2013

There are two init_process methods in the EventletWorker. See:
https://github.com/olt/gunicorn/blob/master/gunicorn/workers/geventlet.py#L48
https://github.com/olt/gunicorn/blob/master/gunicorn/workers/geventlet.py#L91

@benoitc
Copy link
Owner

benoitc commented Dec 9, 2013

Thanks! Maybe you also want to send a PR/patch fixing the problem? If not will make it myself asap.

@olt
Copy link
Contributor Author

olt commented Dec 9, 2013

I don't know which one is the right. :-)
Is hubs.use_hub() required and if, does it need to come before or after patch()?

@benoitc
Copy link
Owner

benoitc commented Dec 9, 2013

hah :) hubs.use_hub() should come before self.patch . both need to be
there if I remember well

On Mon, Dec 9, 2013 at 10:18 AM, Oliver Tonnhofer
notifications@git.luolix.topwrote:

I don't know which one is the right. :-)
Is hubs.use_hub() required and if, does it need to come before or after
patch()?


Reply to this email directly or view it on GitHubhttps://github.com//issues/657#issuecomment-30116606
.

benoitc added a commit that referenced this issue Dec 11, 2013
merge duplicate EventletWorker.init_process method (fixes #657)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants