Send statsd timing metrics in milliseconds #838
Merged
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was excited to see that gunicorn includes statsd reporting now, but I noticed that the times for request duration seemed quite low, and then noticed that it's sending times in seconds instead of milliseconds.
The statsd documentation indicates that timing values are expected to be in milliseconds:
"The glork took 320ms to complete this time"
https://github.com/etsy/statsd/blob/master/docs/metric_types.md#timing
I also confirmed that the Python statsd package is sending timing values in ms instead of s:
https://github.com/jsocol/pystatsd/blob/master/statsd/client.py#L30-L31