Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added timezone to logging #850

Merged
merged 1 commit into from
Aug 13, 2014
Merged

added timezone to logging #850

merged 1 commit into from
Aug 13, 2014

Conversation

silarsis
Copy link
Contributor

As per #847, consistently reporting timezone across all logs

@tilgovi
Copy link
Collaborator

tilgovi commented Aug 13, 2014

Great, though I think prefer it without the square brackets added.

@tilgovi
Copy link
Collaborator

tilgovi commented Aug 13, 2014

Although, maybe it eases parsing?

@silarsis
Copy link
Contributor Author

That was my thought - I initially did it without square brackets, but then though mayching common access log for this might make sense. Happy to change it back, either way.
Sent using CloudMagic
On Thu, Aug 14, 2014 at 3:15 AM, Randall Leeds notifications@github.com wrote:Although, maybe it eases parsing?

—Reply to this email directly or view it on GitHub.

@tilgovi
Copy link
Collaborator

tilgovi commented Aug 13, 2014

We do match common log for the access log by default. Just not so for the error log.
I'll merge this but cc @benoitc in case he feels strongly about it.

tilgovi added a commit that referenced this pull request Aug 13, 2014
added timezone to logging
@tilgovi tilgovi merged commit 0dafa8d into benoitc:master Aug 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants