Explicitly state max_connections and timeout defaults in docs #688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no explicitly stated defaults (that I can find) for
max_connections
andtimeout
.The README examples, if they are examples of the defaults, say
100
formax_connections
but then inhackney.app.src
it seems to be50
? I went with that one but if it is something else, please let me know and happy to update my PR.Either way it would be helpful to have very clearly stated defaults.