Skip to content

Commit

Permalink
Copy and use IWindowDriver in PlaywrightDriver
Browse files Browse the repository at this point in the history
  • Loading branch information
Tyriar committed Nov 12, 2021
1 parent daa8095 commit c65c873
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 23 deletions.
1 change: 0 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -952,7 +952,6 @@
"@vscode/*",
"@parcel/*",
"playwright-core/**",
"**/vs/platform/driver/common/**",
"*" // node modules
]
},
Expand Down
8 changes: 4 additions & 4 deletions src/vs/platform/driver/common/driver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@ export interface IDriver {
getLocaleInfo(windowId: number): Promise<ILocaleInfo>;
getLocalizedStrings(windowId: number): Promise<ILocalizedStrings>;
}
//*END

export const ID = 'driverService';
export const IDriver = createDecorator<IDriver>(ID);

export interface IWindowDriver {
click(selector: string, xoffset?: number | undefined, yoffset?: number | undefined): Promise<void>;
Expand All @@ -76,6 +72,10 @@ export interface IWindowDriver {
getLocaleInfo(): Promise<ILocaleInfo>;
getLocalizedStrings(): Promise<ILocalizedStrings>
}
//*END

export const ID = 'driverService';
export const IDriver = createDecorator<IDriver>(ID);

export interface IDriverOptions {
verbose: boolean;
Expand Down
19 changes: 1 addition & 18 deletions test/automation/src/playwrightDriver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,27 +8,10 @@ import { ChildProcess, spawn } from 'child_process';
import { join } from 'path';
import { mkdir } from 'fs';
import { promisify } from 'util';
import { IDriver, IDisposable } from './driver';
import { IDriver, IDisposable, IWindowDriver } from './driver';
import { URI } from 'vscode-uri';
import * as kill from 'tree-kill';
import { PageFunction } from 'playwright-core/types/structs';
import { IElement, ILocaleInfo, ILocalizedStrings } from '.';

// TODO: Copy driver over to ./driver.d.ts?
export interface IWindowDriver {
click(selector: string, xoffset?: number | undefined, yoffset?: number | undefined): Promise<void>;
doubleClick(selector: string): Promise<void>;
setValue(selector: string, text: string): Promise<void>;
getTitle(): Promise<string>;
isActiveElement(selector: string): Promise<boolean>;
getElements(selector: string, recursive: boolean): Promise<IElement[]>;
getElementXY(selector: string, xoffset?: number, yoffset?: number): Promise<{ x: number; y: number; }>;
typeInEditor(selector: string, text: string): Promise<void>;
getTerminalBuffer(selector: string): Promise<string[]>;
writeInTerminal(selector: string, text: string): Promise<void>;
getLocaleInfo(): Promise<ILocaleInfo>;
getLocalizedStrings(): Promise<ILocalizedStrings>
}

const width = 1200;
const height = 800;
Expand Down

0 comments on commit c65c873

Please sign in to comment.