Update GH Test Matrix with minimum & latest JRuby version #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be an issue with the bundler version at 'appraisal install' in Github action. I'm not sure how to fix it. |
|
@tedhexaflow Thanks for opening this! I fixed the bundler issue on I'd like it if this PR bracketed the JRuby versions: have one value in the matrix for the minimum version of JRuby that GoodJob supports, and one value in the matrix for the latest version of JRuby. |
tedt10e
changed the title
|
@bensheldon Rebased and updated. All checks have passed too. Please let me know if there's anything else I need to do. Many Thanks 💚💙💜 |
|
@tedhexaflow Awesome! Please squash this down to a single commit and I'll merge. Thank you! |
|
@bensheldon Sorry about that. Just squashed and pushed. Thanks 💛💚❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.