Add dashboard for cron-style jobs #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aried3r
force-pushed
the
ar/cron_job_dashboard
branch
from
cf45518 to
f383177
Compare
|
Hmm, the failed test seems like a fluke. I don't think this change should have made it time out. |
bensheldon
approved these changes
Sep 8, 2021
| <%= link_to "All Jobs", root_path, class: ["nav-link", ("active" if current_page?(root_path))] %> | ||
| </li> | ||
| <li class="nav-item"> | ||
| <%= link_to "Cron-style Jobs", cron_jobs_path, class: ["nav-link", ("active" if current_page?(root_path))] %> |
| @@ -102,5 +102,10 @@ def index | |||
| end, | |||
| } | |||
| end | |||
|
|
|||
| def cron_jobs | |||
There was a problem hiding this comment.
Ideally this would be in its own controller: CronSchedulesController.
|
Good suggestions! I didn't know which style you'd prefer, so I didn't create too many new files. I'll try to apply this changes either today or tomorrow. |
|
@aried3r Thank you so much for this! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Since I'm still working on #359, I thought I could implement a very basic dashboard for cron-style jobs. Looks like this:
argsandsetare not being displayed since they could be procs.What do you think?