Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Concurrent::Delay wrapping of database-loading methods #458

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Nov 26, 2021

Fixes #457. If the database is unavailable, these delayed methods would error and preserve the errored state rather than rerunning. Instead, they should just be allowed to error on every call until the database becomes available.

Using memoization, rather than a Concurrent::Delay should be threadsafe enough because the results are idempotent.

@bensheldon bensheldon temporarily deployed to goodjob-remove-db-delay-hgokb1 November 26, 2021 17:33 Inactive
@bensheldon bensheldon merged commit 5156640 into main Nov 26, 2021
@bensheldon bensheldon deleted the remove_db_delay branch November 26, 2021 17:57
@bensheldon bensheldon added the bug Something isn't working label Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear error when database can't be reached
1 participant