Rename GoodJob::BaseController to GoodJob::ApplicationController
#553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
changed the title
GoodJob::BaseController to GoodJob::ApplicationController
Problem: When `config.action_controller.include_all_helpers = false`, helpers are not available by default which leads to `undefined method 'relative_time'`. This is because the controller is named `BaseController` and the helper is named `ApplicationHelper`. > https://api.rubyonrails.org/classes/ActionController/Helpers.html. > In previous versions of Rails the controller will include a helper > which matches the name of the controller, e.g., MyController will > automatically include MyHelper. Solution: Rename `BaseController` to `ApplicationController`. By following the rails naming convention, necessary helpers are automatically included by rails.
bensheldon
force-pushed
the
rename-to-application-controller
branch
from
9069162 to
e5fcf91
Compare
|
@bensheldon thanks for the follow-up commits! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When
config.action_controller.include_all_helpers = false, helpers arenot available by default which leads to
undefined method 'relative_time'.This is because the controller is named
BaseControllerand the helperis named
ApplicationHelper.Solution:
Rename
BaseControllertoApplicationController. By following therails naming convention, necessary helpers are automatically included by
rails.
Close #550.