-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: conda env for bentos in bentostore #3396
Conversation
10f0ffb
to
4723c68
Compare
Codecov Report
@@ Coverage Diff @@
## main #3396 +/- ##
==========================================
- Coverage 31.93% 31.67% -0.26%
==========================================
Files 135 138 +3
Lines 11150 11263 +113
Branches 1839 1856 +17
==========================================
+ Hits 3561 3568 +7
- Misses 7346 7452 +106
Partials 243 243
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw for all newer type we should use https://peps.python.org/pep-0604/ for consistency.
There are some typo here and there. I will dm you on slack for more.
After talking @aarnphm, other than these comments, need to make the following changes
|
74f56af
to
c0be259
Compare
bd9aeb9
to
257467e
Compare
Hi @jjmachan, any updates on this PR? |
Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Update src/bentoml_cli/env_manager.py Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> Update docs/source/guides/envmanager.rst Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> Update docs/source/guides/envmanager.rst Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> Update docs/source/guides/envmanager.rst Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> Update docs/source/guides/envmanager.rst Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> changes
6e488e8
to
f7b6888
Compare
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Env Manager
The env manager allows you to run
bentoml serve
in an isolated environment. This PR adds support for creating conda environmentUsage
The created environment is created under
$BENTOML_HOME/env
if<bento>
is loaded to bentostore. For project-level invocation the created environment is ephemeral.To clean up the environment created,
rm -rf $BENTOML_HOME/env
Before submitting:
guide on how to create a pull request.
make format
andmake lint
script have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.