fix: update formparser for new starlette #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauyon
commented
Feb 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #3569 +/- ##
==========================================
+ Coverage 0.00% 31.29% +31.29%
==========================================
Files 139 140 +1
Lines 11369 11483 +114
Branches 0 1897 +1897
==========================================
+ Hits 0 3594 +3594
+ Misses 11369 7642 -3727
- Partials 0 247 +247
|
aarnphm
reviewed
Feb 15, 2023
ssheng
previously approved these changes
Feb 15, 2023
|
I'm merging this because it is blocking other PRs. @aarnphm, please still give it a review. |
aarnphm
reviewed
Feb 15, 2023
aarnphm
reviewed
Feb 15, 2023
Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
sauyon
force-pushed
the
aiohttp-multipart
branch
from
b3790f9
to
f1b93b1
Compare
aarnphm
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the formparser for starlette==0.25.
@ssheng I've only done basic testing with a simple test, and there's one minor issue below, this may need polishing or we may want to just quickly replace it.