Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support traffic.max_concurrency for api server and runner #3864

Merged
merged 7 commits into from
May 31, 2023

Conversation

frostming
Copy link
Contributor

Signed-off-by: Frost Ming me@frostming.com

What does this PR address?

This PR adds support for traffic configuration for both API server and runners.

The previous timeout setting is moved under traffic field plus a new configuration max_concurrency, which defaults to infinite.

Before submitting:

@frostming frostming requested a review from a team as a code owner May 15, 2023 08:38
@frostming frostming requested review from aarnphm and removed request for a team May 15, 2023 08:38
@frostming frostming force-pushed the feat/max-concurrency branch from 2c5294b to 7bd9b78 Compare May 16, 2023 00:48
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #3864 (b5f5a72) into main (bd56fa9) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3864   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        155     155           
  Lines      12878   12915   +37     
=====================================
- Misses     12878   12915   +37     
Impacted Files Coverage Δ
src/bentoml/_internal/configuration/containers.py 0.00% <ø> (ø)
src/bentoml/_internal/configuration/v1/__init__.py 0.00% <0.00%> (ø)
...c/bentoml/_internal/runner/runner_handle/remote.py 0.00% <0.00%> (ø)
src/bentoml/_internal/server/base_app.py 0.00% <0.00%> (ø)
src/bentoml/_internal/server/http/traffic.py 0.00% <0.00%> (ø)
src/bentoml/_internal/server/http_app.py 0.00% <0.00%> (ø)
src/bentoml/_internal/server/runner_app.py 0.00% <0.00%> (ø)

@frostming frostming requested a review from bojiang May 16, 2023 07:36
frostming added 5 commits May 22, 2023 17:39
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming force-pushed the feat/max-concurrency branch from 9562372 to 4dbd53b Compare May 22, 2023 09:39
aarnphm
aarnphm previously approved these changes May 22, 2023
Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test is pretty minuscule, but this is LGTM

@aarnphm
Copy link
Contributor

aarnphm commented May 22, 2023

Also I suspect the tests might got cancelled because of the timeout. So you might need to increase the default timeout for our github actions.

Signed-off-by: Frost Ming <me@frostming.com>
@bojiang
Copy link
Member

bojiang commented May 26, 2023

Here we see it will be a breaking change over our configuration.
Since there is just an adjustment over the configuration structure, we may not bother our users.
We may make the original timeout optional and do some adapting and migration.

@aarnphm aarnphm merged commit c724628 into bentoml:main May 31, 2023
@frostming frostming deleted the feat/max-concurrency branch June 6, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants