Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bento build cache miss #4153

Merged
merged 1 commit into from
Aug 29, 2023
Merged

fix: bento build cache miss #4153

merged 1 commit into from
Aug 29, 2023

Conversation

xianml
Copy link
Contributor

@xianml xianml commented Aug 29, 2023

What does this PR address?

fix: pip dependency cache miss in bento build stage

the root cause is that the requirement.text generated by pip compile contains some tmp and random annotations like
image

fix this by adding --no-annotate to the pip compile comands

test result :

before:
image
after:
image

Before submitting:

@xianml xianml requested a review from a team as a code owner August 29, 2023 04:08
@xianml xianml requested review from aarnphm and removed request for a team August 29, 2023 04:08
@aarnphm aarnphm merged commit 1b80859 into main Aug 29, 2023
38 of 42 checks passed
@aarnphm aarnphm deleted the fix/build-cache-miss branch August 29, 2023 04:11
@parano
Copy link
Member

parano commented Aug 29, 2023

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants