Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include mounted FastAPI app's OpenAPI components #4212

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: include mounted FastAPI app's OpenAPI components #4212

merged 1 commit into from
Oct 3, 2023

Conversation

RobbieFernandez
Copy link
Contributor

@RobbieFernandez RobbieFernandez commented Sep 28, 2023 •
edited
Loading

What does this PR address?

Fixes #4211

Before submitting:

@RobbieFernandez RobbieFernandez requested a review from a team as a code owner September 28, 2023 02:20
@RobbieFernandez RobbieFernandez requested review from parano and removed request for a team September 28, 2023 02:20
aarnphm
aarnphm approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@aarnphm aarnphm changed the title fix: Include mounted app's OpenAPI schema fix: include mounted FastAPI app's OpenAPI components Oct 3, 2023
@aarnphm aarnphm merged commit b529002 into bentoml:main Oct 3, 2023
42 of 44 checks passed
@aarnphm aarnphm mentioned this pull request Oct 12, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarnphm aarnphm aarnphm approved these changes

@parano parano Awaiting requested review from parano parano is a code owner automatically assigned from bentoml/bentoml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: OpenAPI Schema components from mounted ASGI apps are not being included
2 participants
@RobbieFernandez @aarnphm