fix: refactor deployment v2 client and cli #4383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FogDong
force-pushed
the
1.2
branch
4 times, most recently
from
f03be97
to
2e00f3f
Compare
FogDong
force-pushed
the
1.2
branch
2 times, most recently
from
9a50194
to
eeb0bd7
Compare
FogDong
changed the title
Signed-off-by: FogDong <fog@bentoml.com>
Signed-off-by: FogDong <fog@bentoml.com>
aarnphm
reviewed
Jan 8, 2024
frostming
reviewed
Jan 9, 2024
Signed-off-by: FogDong <fog@bentoml.com>
frostming
reviewed
Jan 9, 2024
frostming
approved these changes
Jan 9, 2024
frostming
added a commit
that referenced
this pull request
Jan 17, 2024
* fix: refactor deployment v2 client Signed-off-by: FogDong <fog@bentoml.com> * refactor cli Signed-off-by: FogDong <fog@bentoml.com> * fix lint Signed-off-by: FogDong <fog@bentoml.com> * resolve comments Signed-off-by: FogDong <fog@bentoml.com> * Update src/bentoml/_internal/cloud/deployment.py * Update tests/unit/_internal/cloud/test_deployment.py --------- Signed-off-by: FogDong <fog@bentoml.com> Co-authored-by: Frost Ming <mianghong@gmail.com>
frostming
added a commit
that referenced
this pull request
Feb 1, 2024
* fix: refactor deployment v2 client Signed-off-by: FogDong <fog@bentoml.com> * refactor cli Signed-off-by: FogDong <fog@bentoml.com> * fix lint Signed-off-by: FogDong <fog@bentoml.com> * resolve comments Signed-off-by: FogDong <fog@bentoml.com> * Update src/bentoml/_internal/cloud/deployment.py * Update tests/unit/_internal/cloud/test_deployment.py --------- Signed-off-by: FogDong <fog@bentoml.com> Co-authored-by: Frost Ming <mianghong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
Fixes #(issue)
Before submitting:
guide on how to create a pull request.
pre-commit run -ascript has passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.