Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metrics did not include 4xx #4756

Merged
merged 2 commits into from
May 28, 2024
Merged

fix: metrics did not include 4xx #4756

merged 2 commits into from
May 28, 2024

Conversation

xianml
Copy link
Contributor

@xianml xianml commented May 27, 2024

What does this PR address?

metrics did not include 4xx like 429
image

Fixes #(issue)

Before submitting:

@xianml xianml requested a review from a team as a code owner May 27, 2024 07:56
@xianml xianml requested review from aarnphm, frostming, a team and larme and removed request for a team May 27, 2024 07:56
@xianml
Copy link
Contributor Author

xianml commented May 27, 2024

@frostming Do we still need change api-server and runner APP under src/bentoml/_internal/server/http_app.py?

@frostming
Copy link
Contributor

I don't think so. BTW why the integration test if failing:

subprocess.CalledProcessError: Command '['/Users/runner/work/BentoML/BentoML/.nox/e2e-testing-3-11-suite-bento_new_sdk/bin/python', '/Users/runner/work/BentoML/BentoML/examples/quickstart/prepare_model.py']' returned non-zero exit status 2.

The error is weird

@xianml
Copy link
Contributor Author

xianml commented May 27, 2024

I don't think so. BTW why the integration test if failing:

subprocess.CalledProcessError: Command '['/Users/runner/work/BentoML/BentoML/.nox/e2e-testing-3-11-suite-bento_new_sdk/bin/python', '/Users/runner/work/BentoML/BentoML/examples/quickstart/prepare_model.py']' returned non-zero exit status 2.

The error is weird

fixed in #4758

Copy link

Code Coverage

Package Statements
bentoml 64.06% (10998 / 17167)
Summary 64.06% (10998 / 17167)

@xianml xianml merged commit 8d22bc7 into main May 28, 2024
42 of 43 checks passed
@xianml xianml deleted the fix/metrics-4xx branch May 28, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants