Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should enable existing loggers in server logging config #4759

Merged
merged 1 commit into from
May 28, 2024

Conversation

rickzx
Copy link
Collaborator

@rickzx rickzx commented May 28, 2024

What does this PR address?

Currently, server logging disables all non-root loggers. This shouldn't be disabled, since users can have their own loggers set up.

Before submitting:

@rickzx rickzx requested a review from a team as a code owner May 28, 2024 01:47
@rickzx rickzx requested review from jianshen92 and removed request for a team May 28, 2024 01:47
@rickzx rickzx merged commit 1e0f07e into main May 28, 2024
41 of 43 checks passed
@rickzx rickzx deleted the pr-fix-server-logger branch May 28, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants