Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: middleware reorder #4761

Merged
merged 1 commit into from
May 30, 2024
Merged

fix: middleware reorder #4761

merged 1 commit into from
May 30, 2024

Conversation

xianml
Copy link
Contributor

@xianml xianml commented May 29, 2024

What does this PR address?

the proper order of middleware is

  1. TrafficMetrics middleware
  2. OpenTelemetry middleware
  3. AccessLog middleware
  4. TimeoutMiddleware
  5. MaxConcurrencyMiddleware
  6. CORS middleware
  7. ContextMiddleware

LOG
image

Metric
image

Fixes #(issue)

Before submitting:

@xianml xianml requested a review from a team as a code owner May 29, 2024 06:38
@xianml xianml requested review from ssheng and removed request for a team May 29, 2024 06:38
@xianml xianml changed the title fix: middleware reordeer fix: middleware reorder May 29, 2024
@xianml xianml requested a review from frostming May 29, 2024 06:40
@frostming
Copy link
Contributor

  1. TrafficMetrics middleware

Is this redundant?

@xianml
Copy link
Contributor Author

xianml commented May 29, 2024

  1. TrafficMetrics
  1. TrafficMetrics middleware

Is this redundant?

only 1 TrafficMetrics middleware. Why redundant?

@frostming
Copy link
Contributor

only 1 TrafficMetrics middleware. Why redundant?

Okay, I mistook it.

Copy link

Code Coverage

Package Statements
bentoml 64.06% (10998 / 17167)
Summary 64.06% (10998 / 17167)

@frostming frostming merged commit c03f2d9 into main May 30, 2024
43 checks passed
@frostming frostming deleted the fix/middleware branch May 30, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants