Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pandas): use correct mime type for Parquet #4780

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

judahrand
Copy link
Contributor

What does this PR address?

It is a shame that BentoML doesn't use the correct mime type for Parquet:
https://www.iana.org/assignments/media-types/application/vnd.apache.parquet

Here we move to using the correct mime type going forwards but accept the old mime type too.

Fixes #(issue)

Before submitting:

@judahrand judahrand requested a review from a team as a code owner June 6, 2024 10:55
@judahrand judahrand requested review from xianml and removed request for a team June 6, 2024 10:55
@judahrand judahrand changed the title fix: use correct mime type for Parquet fix(pandas): use correct mime type for Parquet Jun 6, 2024
@judahrand
Copy link
Contributor Author

@xianml I don't think these test failures are related to my changes

@frostming
Copy link
Contributor

@xianml I don't think these test failures are related to my changes

They are: https://github.com/bentoml/BentoML/actions/runs/9458228250/job/26053392444?pr=4780

@judahrand
Copy link
Contributor Author

@xianml I don't think these test failures are related to my changes

They are: https://github.com/bentoml/BentoML/actions/runs/9458228250/job/26053392444?pr=4780

These failures aren't the ones I'd seen before - I'll look into them!

@judahrand
Copy link
Contributor Author

@xianml I don't think these test failures are related to my changes

They are: https://github.com/bentoml/BentoML/actions/runs/9458228250/job/26053392444?pr=4780

I think I fixed the issue (it was a typo) but the tests seem to still be failing oddly. Passing on some platforms but failing on others which is strange given that my changes have absolutely nothing platform specific. Are these flakes that you're aware of?

@frostming frostming merged commit 0cf7cb2 into bentoml:main Jun 12, 2024
42 checks passed
@frostming
Copy link
Contributor

🎉 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants