fix: add memoization to pkg_version_info
to reduce cpu overhead
#4794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses resource overhead from repeated calls to
pkg_version_info
. This function is called with only a handful of static strings, so it seems reasonable to just memoize the value indefinitely. The function is called in hot regions of the code, for example request json parsing and formatting when checking pydantic versions.Fixes #4784
No tests written, but seems like this should be covered by existing tests.