Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monitoring): support GRPC LogExporter #4808

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

judahrand
Copy link
Contributor

What does this PR address?

Fixes #(issue)

Before submitting:

@judahrand judahrand requested a review from a team as a code owner June 15, 2024 14:45
@judahrand judahrand requested review from jianshen92 and removed request for a team June 15, 2024 14:45
Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the deps check, other wise this LGTM.

@judahrand judahrand requested a review from aarnphm June 17, 2024 08:57
Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@aarnphm aarnphm merged commit e1efdc6 into bentoml:main Jun 17, 2024
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants