-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ASCII animation was not working properly in the image builder logs #4810
Conversation
25fb983
to
38d013c
Compare
38d013c
to
283d199
Compare
0313cc9
to
5c14131
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interfaces of Spinner
don't look good, will refactor later.
5c14131
to
d17fb4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few tiny things, with the types we can upgrade to newer syntax as a whole in a later PR.
d17fb4c
to
0dd9810
Compare
What does this PR address?
👈 BentoML CLI 🆚 kubectl 👉
ascii-animation-4k.mp4
Before submitting:
guide on how to create a pull request.
pre-commit run -a
script has passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.