fix: auto login confirm ask logic #4864

xianml · 2024-07-16T15:34:44Z

What does this PR address?

fix

Fixes #(issue)

Does the Pull Request follow Conventional Commits specification naming? Here are GitHub's
guide on how to create a pull request.
Does the code follow BentoML's code style, pre-commit run -a script has passed (instructions)?
Did you read through contribution guidelines and follow development guidelines?
Did your changes require updates to the documentation? Have you updated
those accordingly? Here are documentation guidelines and tips on writting docs.
Did you write tests to cover your changes?

src/bentoml_cli/cloud.py

xianml requested a review from a team as a code owner July 16, 2024 15:34

xianml requested review from bojiang and frostming and removed request for a team July 16, 2024 15:34

frostming reviewed Jul 17, 2024

View reviewed changes

src/bentoml_cli/cloud.py Outdated Show resolved Hide resolved

xianml force-pushed the fix/open-url branch from 0cc9544 to 9152128 Compare July 18, 2024 06:00

frostming approved these changes Jul 18, 2024

View reviewed changes

xianml changed the title ~~fix: return when not confirmed by user~~ fix: auto login confirm ask logic Jul 18, 2024

Base automatically changed from dev/1.3 to main July 18, 2024 08:04

xianml added 2 commits July 18, 2024 19:13

fix: return when not confirmed by user

b6880d8

chore: update the ask rpel

827970a

xianml force-pushed the fix/open-url branch from 74a6e62 to 827970a Compare July 18, 2024 11:13

xianml requested a review from frostming July 18, 2024 11:18

frostming approved these changes Jul 18, 2024

View reviewed changes

frostming merged commit fab310d into main Jul 18, 2024
49 of 53 checks passed

frostming deleted the fix/open-url branch July 18, 2024 11:33

aarnphm mentioned this pull request Aug 27, 2024

chore(container): install uv directly to container #4941

Open

5 tasks