Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runner): remove keyword args for attrs.get() #661

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix(runner): remove keyword args for attrs.get() #661

merged 1 commit into from
Nov 15, 2023

Conversation

jeffwang0516
Copy link
Contributor

Fix TypeError occured when using openllm.Runner

    lc_llm = OpenLLM(model_name=model_name, model_id=model_id, embedded=False, **attrs)
  File "/opt/conda/lib/python3.8/site-packages/langchain/llms/openllm.py", line 171, in __init__
    runner = openllm.Runner(
  File "/opt/conda/lib/python3.8/site-packages/openllm/_deprecated.py", line 58, in Runner
    model_id = attrs.get('model_id', default=os.getenv('OPENLLM_MODEL_ID', llm_config['default_id']))
TypeError: get() takes no keyword arguments

aarnphm
aarnphm approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@aarnphm aarnphm merged commit af88b9b into bentoml:main Nov 15, 2023
1 check passed
@aarnphm
Copy link
Collaborator

aarnphm commented Nov 15, 2023

But there is a langchain PR upstream langchain-ai/langchain#12968 to use the new API

@jeffwang0516
Copy link
Contributor Author

That’s good to know. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarnphm aarnphm aarnphm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffwang0516 @aarnphm