search within a work

[saracarl]

We have a lot of searches, but not one for within a work

[isabelabarton]

@saracarl I feel like once I find the right place it could look something like this. (including the lines below this line)

fromthepage/app/views/dashboard/landing_page.html.slim

Line 72 in bcdc11b

=form_tag({:controller => 'dashboard', :action => 'landing_page'}, method: :get, enforce_utf8: false, class: 'collection-search') do

Where specifically should there be a search bar? Because there are already search bars in these two spots.

I could, however add one on an actual page, but would it be looking for specific words?

[benwbrum]

I think the most logical place to put this particular search bar is on the screen that users see when they click on a work name, like https://fromthepage.com/benwbrum/jeremiah-white-graves-diaries/jeremiah-white-graves-diary-volume-2-book-13

That's probably somewhere like app/views/display/read_work.

[isabelabarton]

@benwbrum If theres is already a search bar looking in the collection in that spot, what would the new one be looking for?

[benwbrum]

It would only search within that particular work, instead of all the works in the collection.

…

Sent from my iPhone

On Jul 23, 2020, at 2:27 PM, isabelabarton ***@***.***> wrote:  @benbrum If theres is already a search bar looking in the collection in that spot, what would the new one be looking for? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[isabelabarton]

@benwbrum supply 103

fromthepage/app/controllers/display_controller.rb

Lines 96 to 104 in f8b4237

	else
	@search_string = CGI::escapeHTML(params[:search_string])
	# convert 'natural' search strings unless they're precise
	unless @search_string.match(/["+-]/)
	@search_string.gsub!(/(\S+)/, '+\1*')
	end
	# restrict to pages that include that subject
	@pages = Page.order('work_id, position').joins(:work).where(work_id: @collection.works.ids).where("MATCH(search_text) AGAINST(? IN BOOLEAN MODE)", @search_string).paginate(page: params[:page])
	end

[benwbrum]

It looks like all we need to do is replace work_id: @collection.works.ids with work_id: @work.id, as in this:

Page.order('work_id, position').joins(:work).where(work_id: @work.id).where("MATCH(search_text) AGAINST(? IN BOOLEAN MODE)", @search_string).paginate(page: params[:page])