Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalize Active Record Errors #3176

Closed
sylvieed opened this issue Jun 13, 2022 · 0 comments · Fixed by #3178
Closed

Internationalize Active Record Errors #3176

sylvieed opened this issue Jun 13, 2022 · 0 comments · Fixed by #3178
Assignees

Comments

@sylvieed
Copy link
Collaborator

From #1820, helps #3165

Whether or not errors are correctly localized is weirdly inconsistent. A couple of examples:

  • With a bad transcription markup, there is no translation other than English.

  • With a work or collection title that's too short, half of the translation is localized.

  • With an invalid login, the other half of the translation is localized. I think this is because of our Devise locales.

There is a chance that the errors prohibited this... is something that happens when ActiveRecord tries to save a model and fails to find a (very specific) key in a message catalog for the model.

See the first (or best) answer here: https://stackoverflow.com/questions/20676111/rails-i18n-not-working-for-header-error

(Note that that would not explain the five places where we are actually using a ...prohibited this... string literal in the views.)

@sylvieed sylvieed self-assigned this Jun 13, 2022
@sylvieed sylvieed linked a pull request Jun 14, 2022 that will close this issue
@sylvieed sylvieed changed the title Internationalize ActiveRecord Errors Internationalize Active Record Errors Jun 22, 2022
saracarl added a commit that referenced this issue Jul 13, 2022
Internationalized Active Record error messages for #3176
sylvieed pushed a commit that referenced this issue Jul 14, 2022
Internationalized Active Record error messages for #3176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants