Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with French translations #3232

Closed
sylvieed opened this issue Jul 21, 2022 · 28 comments
Closed

Issues with French translations #3232

sylvieed opened this issue Jul 21, 2022 · 28 comments
Labels
i18n Internationalization and localization

Comments

@sylvieed
Copy link
Collaborator

sylvieed commented Jul 21, 2022

There are some issues with the new French translations in the UI, like the wording being too long to fit in buttons, etc. Let's note them here when we see them

@sylvieed sylvieed added the i18n Internationalization and localization label Jul 21, 2022
@sylvieed
Copy link
Collaborator Author

sylvieed commented Jul 21, 2022

  • Toggle for "nightly email with activity in collections you've worked on" in "Edit profile" page is too long

profile- nightly activity toggle

user_activity: E-mail de nuit avec l'activité dans les collections sur lesquelles vous avez travaillé

@sylvieed
Copy link
Collaborator Author

sylvieed commented Jul 21, 2022

  • "Signed in as" on page header is too long, making "..." appear

signed in as

signed_in_as: Connecté en tant que

@sylvieed
Copy link
Collaborator Author

sylvieed commented Jul 21, 2022

  • "Browse" when uploading a file on "Start a Project" page is too long

browse

@sylvieed
Copy link
Collaborator Author

sylvieed commented Jul 21, 2022

  • "Import" when importing a work on "Start a Project" page is too long

import

@sylvieed sylvieed changed the title Some French translations don't fit in UI Issues with French translations in UI Jul 25, 2022
@benwbrum
Copy link
Owner

benwbrum commented Jul 27, 2022

  • Site footer has lower-case "terms et conditions"

Screenshot from 2022-07-27 09-34-59

@benwbrum
Copy link
Owner

benwbrum commented Jul 27, 2022

FindAProject

  • Find A Project's Search button is too narrow

Screenshot from 2022-07-27 09-36-18

  • Also, the placeholder text (which disappears when someone clicks in it) is too long. Rephrase?

"Show more" translated as "Montre plus", but "More.." translated as "Suite..."

Screenshot from 2022-07-27 09-39-09

  • Is this correct usage?

Complete

@saracarl
Copy link
Collaborator

saracarl commented Jul 27, 2022

image

  • Is "Flux 'd'activité" the correct phrase for "activity stream"?
  • missing verb in first deed
  • "travail" instead of "oeuvre" in all deeds
  • Deed type buttons are in English
  • "page transcrite" and "page modifier" need verbs
  • No space between "rejoint" and collection name

@benwbrum
Copy link
Owner

benwbrum commented Jul 27, 2022

Screenshot from 2022-07-27 09-53-45

Page overview

  • Is "Aperçu" the correct name for "overview"
  • Inconsistency between "Notes" and "Remarques". Settle on "Notes"

@benwbrum
Copy link
Owner

benwbrum commented Jul 27, 2022

Page version tab

Screenshot from 2022-07-27 09-55-56

  • Abbreviated months are English. (This seems to be some kind of library -- we should be able to localize dates)
  • Revisions should be pluralized

@saracarl
Copy link
Collaborator

saracarl commented Jul 27, 2022

image

Transcription screen

  • Apercu is used for both "Overview" and the Preview button
  • Capitalize "S" in "sauvguarder"
  • "Needs review" is translated differently in the checkbox, in the first sentence of the warning text, and in the last sentence of the warning text. "Needs" and "review" are both different.

@benwbrum
Copy link
Owner

benwbrum commented Jul 27, 2022

Screenshot from 2022-07-27 10-21-01
image

Work Contents

  • "Remarques" instead of "Notes"
  • Buttons are not translated ("Review" instead of French)
  • "4 note" isn't pluralized

@benwbrum
Copy link
Owner

benwbrum commented Jul 27, 2022

Download screen

  • "travail" intstead of "oeuvre"
  • What should we translate "Facing PDF" to?

@benwbrum
Copy link
Owner

benwbrum commented Jul 27, 2022

Screenshot from 2022-07-27 10-24-06

About screen (work)

  • "Uploaded by" is "téléchargé par", which probably means "downloaded by"

@benwbrum
Copy link
Owner

benwbrum commented Jul 27, 2022

Read Work screen

  • Status bar for page needing review says "a besoin d'examen". Button for pages needing review says "à reviser".
  • Search button is too narrow for "Chercher"

@benwbrum
Copy link
Owner

benwbrum commented Jul 27, 2022

Collection show screen

  • Remarques vs. Notes in activity stream title
  • "needs review" consistency issue in work status bars
  • Search button too narrow
  • "Show more" translation missing
  • will_paginate model passed in (Work) isn't translated

@saracarl
Copy link
Collaborator

saracarl commented Jul 27, 2022

image

Collection activity stream/note list

  • "Collecte" instead of "Collection"
  • Deed type button
  • Travail instead of oeuvre
  • Quoted note contents begin with an open guillemet but end with high-9 quotes.

@benwbrum
Copy link
Owner

benwbrum commented Jul 27, 2022

Screenshot from 2022-07-27 10-36-18

New User Dashboard

  • missing space between wording and the hyperlink to "collections" in final sentence.

@saracarl
Copy link
Collaborator

saracarl commented Jul 27, 2022

image

Collection statistics page

  • "Oeuvres" instead of "Travaillers"
  • "Notes" instead of "Noters"
  • "Sujets" instead of "Matieres"
  • Pages needing review
  • Pages reviewed
  • "Page edits" needs retranslating
  • Pages needing review (recent statistics)
  • Page edits (recent stats)
  • "Noters" (recent stats)

@saracarl
Copy link
Collaborator

saracarl commented Jul 27, 2022

image

Subject article screen

  • "Reglages" as tab label vs. "Onglet parametres" in text
  • "La description"
  • Connected subjects -- is "connexes" correct?
  • "renvoient" -- is that correct?
  • "Afficher" vs "Lis" vs. "Lire" for "read"
  • Untranslated graph title in image (below)
    Screenshot from 2022-07-27 10-49-54

@benwbrum
Copy link
Owner

benwbrum commented Jul 27, 2022

Subject edit screen

  • "La description" instead of "Description"

@benwbrum
Copy link
Owner

benwbrum commented Jul 27, 2022

Translate page screen

  • Untranslated button labels for "Show Transcription"/"Show Image"

@sylvieed
Copy link
Collaborator Author

sylvieed commented Aug 1, 2022

Dates

  • Date formats are not changes when locale is changed to French because we specify the format

-selected_version_date = @selected_version.created_on.localtime.strftime("%b %d, %Y %I:%M %p")

In the Page Versions page, but might be in other places as well.

@sylvieed
Copy link
Collaborator Author

sylvieed commented Aug 1, 2022

Devise error message

When you input an incorrect password when signing in to be a transcriber, the error message "Invalid Login or password." isn't translated.

We should find where this & other error messages are coming from. However, it's also probably OK if this isn't translated.

image

Update

Because this message actually does have a French translation (here), we think this is due to heartcombo/devise#5247 so to avoid creating a larger issue with thread safety, we're going to ignore this issue until/unless a customer reports it.

@sylvieed
Copy link
Collaborator Author

sylvieed commented Aug 1, 2022

  • Work contents action buttons (except for describe) aren't translated (their translations are missing)

@sylvieed
Copy link
Collaborator Author

sylvieed commented Aug 1, 2022

OpenSeadragon

  • On the page image viewer settings, tooltips are not translated

@benwbrum
Copy link
Owner

benwbrum commented Aug 3, 2022

Start a project page issues

Screenshot from 2022-08-03 08-00-34

  • "Import" buttons are too narrow
  • Missing space between "Importer" and "ou"
  • "Upload" button ("Parcourir") is too narrow

@benwbrum
Copy link
Owner

benwbrum commented Aug 3, 2022

Work settings screen

Screenshot from 2022-08-03 09-12-42

  • The check box and the "allow collaborators to modify page titles" label are on different lines.

@benwbrum
Copy link
Owner

benwbrum commented Aug 3, 2022

Add new page lightbox

Screenshot from 2022-08-03 09-21-14

  • too small for the buttons

@sylvieed sylvieed changed the title Issues with French translations in UI Issues with French translations Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Internationalization and localization
Projects
None yet
Development

No branches or pull requests

3 participants