Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ampersands still showed incorrectly on some pages #3284

Closed
sylvieed opened this issue Aug 26, 2022 · 0 comments · Fixed by #3285
Closed

Ampersands still showed incorrectly on some pages #3284

sylvieed opened this issue Aug 26, 2022 · 0 comments · Fixed by #3285
Assignees
@sylvieed

Comments

@sylvieed
Copy link
Collaborator

sylvieed commented Aug 26, 2022 •
edited
Loading

See #2994 and #3268. In these 2 PRs, we changed how we strip tags from collections' intro_blocks on the Find a Project page so that ampersands and other special characters would be shown correctly.
However, there are some other pages (collection show, collections list, owner profile, etc.) that still use strip_tags to create these shortened intro snippets. We should change them to use the same helper method used for the Find a Project page.

Some examples:

Owner profile
owner profile

Collection overview
collection overview

Guest dashboard
guest dashboard
@sylvieed sylvieed changed the title Ampersands still not escaped on some pages Ampersands still showed incorrectly on some pages Aug 26, 2022
sylvieed added a commit that referenced this issue Aug 26, 2022
@sylvieed
Make all description snippets use to_snippet for #3284
d87de32
@sylvieed sylvieed mentioned this issue Aug 26, 2022
Merged
@sylvieed sylvieed linked a pull request Aug 26, 2022 that will close this issue
Make all description snippets use to_snippet for #3284 #3285
Merged
@sylvieed sylvieed self-assigned this Aug 26, 2022
benwbrum added a commit that referenced this issue Aug 26, 2022
@benwbrum
Merge pull request #3285 from benwbrum/3284-fix-ampersands-everywhere
dfd15a1 
Make all description snippets use to_snippet for #3284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sylvieed sylvieed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make all description snippets use to_snippet for #3284 benwbrum/fromthepage
2 participants
@benwbrum @sylvieed