Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip landing page for logged-in users #3639

Closed
benwbrum opened this issue May 9, 2023 · 2 comments · Fixed by #3733
Closed

Skip landing page for logged-in users #3639

benwbrum opened this issue May 9, 2023 · 2 comments · Fixed by #3733
Assignees

Comments

@benwbrum
Copy link
Owner

benwbrum commented May 9, 2023

The new landing page has two very clear calls to action, Start a Trial and Sign in as Transcriber. Both of these are focused on new site visitors, not existing project owners or volunteers, and this was mentioned by LVA.

We should consider redirecting from the landing page if logged_in? == true, either to the role-appropriate dashboard or to the findaproject page.

@saracarl
Copy link
Collaborator

So we want folks to be able to get to the landing page, but most folks won't need or want to see it.

Let's implement the above, but make the logo in the upper left hand side of the screen take you back to the landing page. We'll need to add a /landing route back in to take you to that page without the redirect.

@benwbrum
Copy link
Owner Author

We think that this can be accomplished by this:

  • Create a #landing route that takes the user to the landing page action currently displayed at the root route.
  • Link the FromThePage logo in the application layout to the #landing route instead of the root route
  • Modify the action at the application root to check whether the user is logged in, then redirect them to their dashboard if they are logged in, or to the landing page if they are not.

To test:

  • As a non-logged in user, visit the root path
    • Verify that you can see the landing page
    • Verify that you can click to the rest of the application
  • As a transcriber, visit the root path
    • Verify that you see the collaborator dashboard
    • Click the FromThePage logo
    • Verify that you see the landing page
  • As a project owner, visit the root path
    • Verify that you see the owner dashboard
    • Click the FromThePage logo
    • Verify that you see the landing page
  • As a site visitor, click on the "I want to transcribe"
    • Create an account
    • Verify that you are not directed to the landing page
  • As a site visitor, click on the "I want to upload documents"
    • Create an account
    • Verify that you are not directed to the landing page

@benwbrum benwbrum linked a pull request Aug 9, 2023 that will close this issue
benwbrum added a commit that referenced this issue Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants