Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forums broken with 500 error due to new landing_path #3758

Closed
saracarl opened this issue Aug 24, 2023 · 1 comment · Fixed by #3760
Closed

forums broken with 500 error due to new landing_path #3758

saracarl opened this issue Aug 24, 2023 · 1 comment · Fixed by #3760
Assignees
Labels
transcriber issues affecting transcriber happiness

Comments

@saracarl
Copy link
Collaborator


I, [2023-08-24T13:36:00.609342 #3485]  INFO -- :   Rendered thredded/messageboard_groups/show.html.erb within layou
ts/application (Duration: 114.8ms | Allocations: 36359)

F, [2023-08-24T13:36:01.441046 #3485] FATAL -- :   
ActionView::Template::Error (undefined method `landing_path' for #<#<Class:0x00007f2def4e3d28>:0x00007f2def4e1aa0>)
:
    35:     header.header
    36:       .toolbar
    37:         .toolbar_group
    38:           =link_to landing_path(logo: true), class: 'logo', title: t('.home'), 'aria-label' => t('.home')
    39:             -if USE_PNG_LOGO
    40:               =image_tag 'logo.png', width: 134, height: 50, alt: t('.home')
    41:             -else
  
app/views/layouts/application.html.slim:38

To reproduce you'll need to enable forums for a collection and then navigate to the forums tab on the collection

@saracarl saracarl added the transcriber issues affecting transcriber happiness label Aug 24, 2023
@benwbrum
Copy link
Owner

This can probably be resolved by prefixing landing_path with main_app so that our application renders within the context of the Thredded engine.

@symmetrically symmetrically self-assigned this Aug 24, 2023
@benwbrum benwbrum linked a pull request Aug 27, 2023 that will close this issue
benwbrum added a commit that referenced this issue Sep 8, 2023
#3758 fixed broken forum on collection show page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transcriber issues affecting transcriber happiness
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants