Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with bulk approval #3917

Closed
anabasftp opened this issue Jan 12, 2024 · 1 comment · Fixed by #3926
Closed

Issue with bulk approval #3917

anabasftp opened this issue Jan 12, 2024 · 1 comment · Fixed by #3926
Assignees
Labels

Comments

@anabasftp
Copy link
Collaborator

Susan Page of LVA emailed us to tell us about a problem with one of their collections, the Virginia Untold: Bills of Sale and Deeds collection. When she goes to the Pages That Need Review in this document set, it shows "no pages found". When she clicks on one of the pages on the list, it shows as Complete with no pages needing review.

However, when she tries to transfer those works to the document set that she created for tracking her exports (https://fromthepage.com/lva/virginia-untold-bills-of-sale-and-deeds-ready-for-export), they don't move:

image

After clicking Transfer, the works are still in https://fromthepage.com/lva/virginia-untold-bills-of-sale-and-deeds-set:

image

Sonya looked at the pages and noticed that the transcriptions are all from "super users." She says she used FTP's new(ish) bulk approvals option via the Review Dashboard to approve pages like these and this is the first collection where she's used that tool. So it could be a bulk approval issue.

@benwbrum
Copy link
Owner

The work statistics are not being recalculated after an approve all. We need to add the appropriate code here: https://github.com/benwbrum/fromthepage/blob/development/app/controllers/collection_controller.rb#L68

@benwbrum benwbrum assigned symmetrically and unassigned saracarl Jan 12, 2024
benwbrum added a commit that referenced this issue Jan 30, 2024
#3917 solved statistics were not being recalculated after bulk approval -- tested and reviewed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants