Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links clicked in read views replace current tab #3937

Closed
saracarl opened this issue Jan 30, 2024 · 1 comment · Fixed by #4262
Closed

links clicked in read views replace current tab #3937

saracarl opened this issue Jan 30, 2024 · 1 comment · Fixed by #4262
Assignees
Labels

Comments

@saracarl
Copy link
Collaborator

New Bedford puts html links into their transcriptions. If you click on one of the, they replace the current tab.

https://www.fromthepage.com/nbwm/logbooks-and-journals/kwm-482/display/32946693

https://app.intercom.com/a/inbox/kp250kj7/inbox/shared/all/conversation/139745300094089?view=List

I can't tell if they want links to open a new tab in the overview/read views of FtP, or in the exports. (We don't support links in their favorite pdf exports right now, anyway.)

@benwbrum
Copy link
Owner

Can we update the a tags which we display to dynamically add a target attribute so that they open in a different tab when users are viewing the read_work or display actions? I don't want to do any such update in the exports, so this should just be in the xml_to_html methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants