3937 - Links clicked in read views replace current tab #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillNigel23
commented
Aug 6, 2024
| my_display_html.strip, | ||
| tags: SANITIZE_ALLOWED_TAGS, | ||
| attributes: SANITIZE_ALLOWED_ATTRIBUTES | ||
| ).gsub('<br>','<br/>').gsub('<hr>','<hr/>') |
There was a problem hiding this comment.
It seems the sanitize function is stripping 'target' attributes on hrefs.
We can deal with this by whitelisting href and target, but passing in attributes is restrictive rather than additive so I declared SANITIZE_ALLOWED_ATTRIBUTES above.
I may have missed some attributes there but I prioritized obvious ones and those that are explicitly used here in xml_to_html function.
NOTE:
Users will still have to add target="_blank" or "new" as done here:
https://www.fromthepage.com/nbwm/logbooks-and-journals/kwm-482/display/32946693
Let me know if this is okay
WillNigel23
commented
Aug 6, 2024
| @@ -24,6 +26,11 @@ | |||
| expect(xml_to_html(@xml_text, false, true)).to include("Faith<span class=\"line-break\"></span>fully") | |||
| end | |||
|
|
|||
| it 'returns a <a> tag with preserved href and target attributes' do | |||
| expect(xml_to_html(@xml_text, true, true)).to include(@a_tag_with_attr) | |||
There was a problem hiding this comment.
added specs to test new functionality
|
This is tested and can be merged as soon as it passes spec tests. |
benwbrum
deleted the
3937-links-clicked-in-read-views-replace-current-tab
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.