accept any work slug with alphabet characters or a dash or underscore #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works as described. However, when testing a non-Latin slug like ל"עולם, the slug I entered is replaced with a GUID. Is that correct behavior? |
sylvieed
pushed a commit
that referenced
this pull request
Jul 14, 2022
accept any work slug with alphabet characters or a dash or underscore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LVA has work titles with underscores or dashes, which were not allowed with the alpha regex matching. Since they upload large zip files, we would get 80% of the way through, run into one of these, and then fail for the entire upload.